Expand menu items when list icon clicked

href=#

Please use valid markup. :)

Yeah, sorry for not being more clear. I'm not spending a lot of time here this week. The validation issue I meant was only the attribute quotes.

Personally, I like to put "javascript:void()" instead of "#" in links that are supposed to be Javascript-only (avoids jumping to the top of the page when JS is disabled), but as this link is generated by Javascript, that's superfluous.

subscribing

BTW: I recall doing some thing like this before, but dropped it because of cross-browser compatibility (it didn't worked the same in a couple of them, right now I don't remember which ones)

Thanks, I'll test this now.

This will fortunately not require any porting since D7 already has icon-expansion functionality.

Hi, I'm sorry but this doesn't work (and work at all) on my test site. You can check the demo here: http://dev.ermarian.net/dhtml_menu/ . As soon as you enable the new setting, everything is broken.

Basically, icons overlap with the link text, and neither clicking the link text nor the icon will actually cause anything to expand.

Subscribing

http://drupal.org/files/issues/dhtml_menu_8.patch

vs. Drupal 6.6+dhtml_menu-6.x-3.2

I agree it does not work properly yet.

Case 1:

• [y] Animating sliding effect
• [n] Go to the page on double-click
• [y] Menus expand/collapse when icon clicked.

Clicking on link (not icon) of parent opens parent page: OK
Clicking on icon of OPEN parent closes branch: OK
Clicking on icon of CLOSED parent: FAILS: parent branch opens and closes immediately

Case 2:

• [n] Animating sliding effect
• [n] Go to the page on double-click
• [y] Menus expand/collapse when icon clicked.

Clicking on link (not icon) of parent opens parent page: OK
Clicking on icon of OPEN parent closes branch: OK
Clicking on icon of CLOSED parent: opens branch OK however then goes to 'parent#' and to bottom of page

BTW (I had Pathologic 6.x-1.1-beta13 on, toggling it and reloading had no effect.)

Please persist, this could be a very useful improvement to DHTML, and Happy New Year in 2009 (from Sydney).

PS: did not find '#' in patched .module.
Any idea where it comes from ?
If I can get rid of that I at least have a working non-animated solution.

If you refer to the link element, it is generated by Javascript.

Thanks Arancaytar,

From dhtml_menu.js:

// $Id: dhtml_menu.js,v 1.18.2.8 2008/11/09 23:03:35 arancaytar Exp $
..
    if(effects.iconclick) {
  	  $(li).find('a:first').addClass('menu-link');
  	  $(li).prepend('<a href="#" class="icon-link"></a>');
    }      	 

I hacked it to read:

    if(effects.iconclick) {
  	  $(li).find('a:first').addClass('menu-link');
  	  $(li).prepend('<a href="" class="icon-link"></a>');
    }      	

And now it seems to work exactly as I wish (as long as the animation mode is off).

Am most grateful for your help.

May I ask why the '#' is there in the first place ?

I wrote:
> May I ask why the '#' is there in the first place ?

I was premature in my delight that my hack worked, it was an illusion.

If one waits a bit in fact the current page simply reloads whenever the icon link (with '#') is clicked.

!!! Can somebody please examine this and attempt a solution compatible with Drupal6.6. !!!

There have to be hundreds of drupal developers and maybe thousands of users who want
to be able to open and close branch icons and single click on a parent link to open its page.

#349269: Double clicking is unnatural

And I agree, and so do lots of others. Please persist. I would be very, very grateful.

> a solution compatible with Drupal6.6. !!!
Better said, compatible with secure Drupal6.8

Works great so far!
I'm using Zen theme btw ;)

Thanks!!

EDIT: It has problems when using the "Keep only one menu open at a time" option. Menus will expand and automatically collapse again.

Subscribe + Report:

The patch works ad advertised, which is exactly what i was looking for. I tried jquery menu, but the animations and ability to know which menu should be open were sub par. This module is perfect, and was actually trying to figure out how i could get this effect out of it.

That being said, have the same problem as reported above. Where if i have it set to keep only 1 menu item open at a time, it will auto close them. I'm looking through the javascript to see if i can figure out what's making them auto close.

Subscribing

+1 for this patch. I'd like it much more if clicking the link would open the page, and clicking the icon would open the tree.

It has problems when using the "Keep only one menu open at a time" option. Menus will expand and automatically collapse again.

You may need to stop bubble propagation of the event - I experienced the same issue when I implemented "li"-clickable expansion. Nested elements will all get the event unless it gets canceled. I haven't looked at it in detail though.

Note that a feature like this already exists in the D7 branch, and I unfortunately won't be able to spend time backporting it to D6. I will gladly review and commit a working patch though. :)

Forgot to change Status.
Subscribing.

subscribing - this would be incredibly useful for us. having something more stable than a patch for D6 would save our menu.

It has problems when using the "Keep only one menu open at a time" option. Menus will expand and automatically collapse again.

This patch is going nowhere while that still happens, unfortunately...

This feature is in D7 now. Once the present overhaul is done, the D7 version will be backported to D6 as version 6.x-4.0. That means that 6.x-3.x no longer needs a patch for the feature.

Hi

I applied the patch. a few things still don't work. so I set this to active again.

I installed 6.x-3.5 but there is no backport yet?
Still planning to do so?

Patch does not work on 6.x-3.5.
double click still needed, icon not clickable.

active sub-links are not visible (collapsed).

subscribing.

When is planned the back-porting from D7 (or when is planned the 6.x-4.0 version ;) )?

Subscribing.
Any progress on the mentioned backport?

EDIT: Ah, I can see there is a 6.x-4.x-dev version kicking around with the backport in it.
I'll have a play with it to see how stable it is.

EDITED EDIT: Well the short answer is: It isn't! All sorts of problems with that version, its very broken.

EDITED EDITED EDIT: Hmmm. Mostly works on a clean install, so it must have a problem with one of the modules I have installed. Hell if I know which one, though.
One problem it has it that the folder icons aren't themselves clickable, its just the bullets. That seems wrong to me.

The patches at http://drupal.org/node/564428#comment-2862258 seem to work pretty well with 6.x-3.5.

I close the issue as Fixed. It is already applied to the 6.x branch.